The Wayback Machine - https://web.archive.org/web/20220323181742/https://github.com/nodejs/node/pull/9560
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: simplify process.memoryUsage() example code #9560

Closed
wants to merge 1 commit into from

Conversation

watson
Copy link
Member

@watson watson commented Nov 12, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
  • doc
Description of change

Using util.inspect doesn't change the output in this case

Using util.inspect doesn't change the output in this case
@nodejs-github-bot nodejs-github-bot added doc process labels Nov 12, 2016
@MylesBorins
Copy link
Member

@MylesBorins MylesBorins commented Nov 12, 2016

LGTM

can confirm the example works as expected on v4.x -> master

Trott
Trott approved these changes Nov 12, 2016
Copy link
Member

@Trott Trott left a comment

LGTM

Copy link
Member

@addaleax addaleax left a comment

LGTM

@silverwind
Copy link
Contributor

@silverwind silverwind commented Nov 13, 2016

Thanks! Landed in 4b35f25.

@silverwind silverwind closed this Nov 13, 2016
silverwind added a commit that referenced this issue Nov 13, 2016
Using util.inspect doesn't change the output in this case

PR-URL: #9560
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@watson watson deleted the patch-1 branch Nov 13, 2016
MylesBorins pushed a commit that referenced this issue Nov 18, 2016
Using util.inspect doesn't change the output in this case

PR-URL: #9560
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this issue Nov 18, 2016
Using util.inspect doesn't change the output in this case

PR-URL: #9560
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins added a commit that referenced this issue Nov 19, 2016
Using util.inspect doesn't change the output in this case

PR-URL: #9560
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax added a commit that referenced this issue Nov 22, 2016
Using util.inspect doesn't change the output in this case

PR-URL: #9560
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
@MylesBorins MylesBorins mentioned this pull request Nov 22, 2016
mmg131440
Copy link

@mmg131440 mmg131440 commented on cf17cbf Mar 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc process
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.