The Wayback Machine - https://web.archive.org/web/20220112120237/https://github.com/scikit-learn/scikit-learn/pull/22167
Skip to content
Sign up
Sign in
Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Fix misleading info in pylatest_pip_openblas_pandas build #22167

Merged
merged 1 commit into from Jan 10, 2022
Merged

CI Fix misleading info in pylatest_pip_openblas_pandas build #22167

merged 1 commit into from Jan 10, 2022

Conversation

@lesteve
Copy link
Member

@lesteve lesteve commented Jan 10, 2022

  • it is not using MKL as the name implies (pylatest_pip_openblas_pandas)
  • PANDAS_VERSION is only used when dependencies are installed with conda or mamba, see

    scikit-learn/build_tools/azure/install.sh

    Line 59 in 49588ff

    TO_INSTALL="$TO_INSTALL $(get_dep pandas $PANDAS_VERSION)"
jjerphan
jjerphan approved these changes Jan 10, 2022
View changes
Copy link
Member

@jjerphan jjerphan left a comment

Thanks for spotting this, @lesteve.

@thomasjpfan thomasjpfan changed the title Fix misleading comment and remove unused variable in pylatest_pip_openblas_pandas Azure build CI Fix misleading comment and remove unused variable in pylatest_pip_openblas_pandas Azure build Jan 10, 2022
thomasjpfan
thomasjpfan approved these changes Jan 10, 2022
View changes
Copy link
Member

@thomasjpfan thomasjpfan left a comment

LGTM

@thomasjpfan thomasjpfan changed the title CI Fix misleading comment and remove unused variable in pylatest_pip_openblas_pandas Azure build CI Fix misleading info in pylatest_pip_openblas_pandas build Jan 10, 2022
@thomasjpfan thomasjpfan merged commit 5d7dc4b into scikit-learn:main Jan 10, 2022
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan

@jjerphan jjerphan

Assignees
No one assigned
Labels
Build / CI
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
3 participants
@lesteve @thomasjpfan @jjerphan
Morty Proxy This is a proxified and sanitized view of the page, visit original site.