The Wayback Machine - https://web.archive.org/web/20220110180011/https://github.com/github/codeql/pull/7489
Skip to content
Sign up
Sign in
Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix example in JavaScript query #7489

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix example in JavaScript query #7489

wants to merge 2 commits into from

Conversation

@edoardopirovano
Copy link
Contributor

@edoardopirovano edoardopirovano commented Dec 29, 2021

Closes #7488

Fixes the issues with the example pointed out in the linked issues.
@edoardopirovano edoardopirovano requested a review from as a code owner Dec 29, 2021
@github-actions github-actions bot added the JS label Dec 29, 2021
@edoardopirovano edoardopirovano mentioned this pull request Dec 29, 2021
Open
Naman-ntc
Naman-ntc reviewed Dec 29, 2021
View changes
Copy link

@Naman-ntc Naman-ntc left a comment

Hi,
I think the comments are still not completely relevant to the type-confusion vulnerability.
For example, in TypeConfusionThroughParameterTampering.js file, I would write something along the lines of BAD : user-controlled file variable can be of type array causing exception.

@edoardopirovano @asgerf
Apply suggestions from code review
081765c 
Co-authored-by: Asger F <asgerf@github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asgerf asgerf

@Naman-ntc Naman-ntc

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

JavaScript type confusion documentation example mistake
3 participants
@edoardopirovano @asgerf @Naman-ntc
Morty Proxy This is a proxified and sanitized view of the page, visit original site.