The Wayback Machine - https://web.archive.org/web/20220108160520/https://github.com/github/codeql/pull/7529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QL: recognize dependecies of the form: libraryPathDependencies: library-name #7529

Open

erik-krogh wants to merge 3 commits into github:main from erik-krogh:fixup-library-deps

Contributor

erik-krogh commented Jan 6, 2022

I added QL-for-QL to an internal project of mine, and QL-for-QL didn't recognize the dependency in a qlpack.yml file of the following form:

name: my-ql-thing
version: 0.0.0
libraryPathDependencies: codeql-ql  # <- this one wasn't recognized.

The text was updated successfully, but these errors were encountered:


          QL: recognize dependecies of the form: libraryPathDependencies: libra…

9afd360

…ry-name

erik-krogh requested a review from tausbn as a code owner

github-actions bot added the QL-for-QL label

tausbn reviewed

View changes

Contributor

tausbn left a comment

One suggestion, otherwise looks good to me.

Also: I trust that this actually works, but perhaps we should have tests for this? (I'm thinking especially of when I start ripping out the "YAML" parser.)

ql/ql/src/codeql_ql/ast/Ast.qll Outdated Show resolved Hide resolved

erik-krogh dismissed tausbn’s stale review via

bb94c42

erik-krogh and others added 2 commits


          explicit this

bb94c42

Co-authored-by: Taus <tausbn@github.com>


          add test

cc5e9fe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment