QL: add "modelling/modeling" to ql/non-us-spelling
#7458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You could also add modelled/modeled. |
owen-mc
approved these changes
Dec 21, 2021
tausbn
approved these changes
Jan 3, 2022
Python looks good. One minor comment about the QL.
| // analyses (as a noun) is fine | ||
| s.regexpMatch(".*analyse[^s].*") and | ||
| wrong = "analyse" |
There was a problem hiding this comment.
Perhaps it would make more sense to use an explicit word-boundary match, so something like s.regexpMatch(".*\\b" + wrong + "\\b.*").
There was a problem hiding this comment.
Good point.
But I think I'll wait with that until we encounter FPs.
With the current approach we also catch when the bad spelling is used as a prefix/suffix.
(But luckily English is not like Danish, so that will be rare).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
/cc @intrigus-lgtm
I also made a patch thing that automatically fix the issues found by the new query.
The text was updated successfully, but these errors were encountered: