The Wayback Machine - https://web.archive.org/web/20220106232808/https://github.com/github/codeql/pull/7431
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solorigate: Extract to separate qlpack #7431

Merged
merged 3 commits into from Jan 6, 2022

Conversation

@aeisenberg
Copy link
Contributor

@aeisenberg aeisenberg commented Dec 16, 2021

Extracts solorigate to separate qlpacks in preparation for publishing them to the registry.

@aeisenberg aeisenberg requested a review from as a code owner Dec 16, 2021
@aeisenberg aeisenberg marked this pull request as draft Dec 16, 2021
@aeisenberg aeisenberg removed the request for review from Dec 16, 2021
@aeisenberg aeisenberg force-pushed the aeisenberg/solorigate-publish branch from 9b41b5c to d8ee792 Dec 16, 2021
@github-actions github-actions bot added the JS label Dec 16, 2021
@aeisenberg aeisenberg force-pushed the aeisenberg/solorigate-publish branch from d8ee792 to c5de00b Dec 17, 2021
Extracts solorigate to separate qlpacks in preparation for
publishing them to the registry.
@aeisenberg aeisenberg force-pushed the aeisenberg/solorigate-publish branch from c5de00b to 50ee4ab Dec 17, 2021
@aeisenberg aeisenberg marked this pull request as ready for review Dec 17, 2021
@aeisenberg aeisenberg requested a review from as a code owner Dec 17, 2021
@aeisenberg aeisenberg requested review from dbartol and Dec 17, 2021
@aeisenberg
Copy link
Contributor Author

@aeisenberg aeisenberg commented Dec 17, 2021

Solorigate queries are now available from the package registry. Run them like this:

codeql database analyze --format=sarif-latest --output=out --download <any-csharp-db> codeql/csharp-solorigate-queries

@aeisenberg
Copy link
Contributor Author

@aeisenberg aeisenberg commented Dec 17, 2021

This PR also includes a simple script to re-publish and version bump.

@@ -0,0 +1,9 @@
name: codeql/solorigate-queries
Copy link
Contributor

@hvitved hvitved Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this mention csharp?

Copy link
Contributor Author

@aeisenberg aeisenberg Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I made the change. Unpublished previous packs and re-published under the new name.

Copy link
Contributor

@hvitved hvitved Dec 20, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to push the change?

Copy link
Contributor Author

@aeisenberg aeisenberg Jan 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed to the wrong remote. Should be good now.

@@ -0,0 +1,8 @@
name: codeql/solorigate-all
Copy link
Contributor

@hvitved hvitved Dec 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this mention csharp?

@aeisenberg aeisenberg force-pushed the aeisenberg/solorigate-publish branch from 2d35ec4 to 7a38618 Jan 4, 2022
codeql/solorigate-all: "*"
codeql/solorigate-queries: "*"
Copy link
Contributor

@hvitved hvitved Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be updated, right?

Copy link
Contributor Author

@aeisenberg aeisenberg Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. Done.

hvitved
hvitved approved these changes Jan 6, 2022
@aeisenberg
Copy link
Contributor Author

@aeisenberg aeisenberg commented Jan 6, 2022

Thanks @hvitved for reviewing!

@aeisenberg aeisenberg merged commit 6d62227 into github:main Jan 6, 2022
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.