The Wayback Machine - https://web.archive.org/web/20220108161004/https://github.com/github/codeql/pull/7400
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for creating change notes. #7400

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

@dbartol
Copy link
Contributor

@dbartol dbartol commented Dec 14, 2021

No description provided.

@dbartol dbartol requested a review from adityasharad Dec 14, 2021
@dbartol dbartol requested a review from aeisenberg Dec 14, 2021
Adding change notes.md Outdated Show resolved Hide resolved
Adding change notes.md Outdated Show resolved Hide resolved
Adding change notes.md Outdated Show resolved Hide resolved
Adding change notes.md Outdated Show resolved Hide resolved
Adding change notes.md Outdated Show resolved Hide resolved
@dbartol dbartol mentioned this pull request Dec 14, 2021
@@ -0,0 +1,69 @@
# Adding change notes for query and library changes

Each CodeQL query pack or library pack has its own change log to track how that pack changes with each release. Any non-trivial, user-visible change to a query or library should add a change note to the affected pack. This document describes how to do that.
Copy link
Contributor

@aeisenberg aeisenberg Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a change note validation step as part of CI. It should just ensure the change notes are well-formed. Not blocking for this change, though.

Copy link
Contributor Author

@dbartol dbartol Dec 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's the plan. Probably just a switch to codeql pack changelog or something.

dbartol and others added 3 commits Dec 14, 2021
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
Copy link
Collaborator

@adityasharad adityasharad left a comment

Nice. I'm happy with this and we can keep improving it over time. Up to you if you want further review from the language teams, as they will be the ones writing these notes.

@dbartol
Copy link
Contributor Author

@dbartol dbartol commented Dec 14, 2021

Leaving this open for a day or so to allow for more comments.

docs/change-notes.md Outdated Show resolved Hide resolved
Copy link
Contributor

@jbj jbj left a comment

Looks great!

Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
Copy link
Contributor

@aeisenberg aeisenberg left a comment

:shipit:

Since this is a change to how users will contribute queries to this repository, it seems like we should add a change note somewhere about this change note. I don't think we need to be putting it into the change notes for the individual libraries, but possibly we can add a note to the CodeQL CLI with a pointer to these new instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.