The Wayback Machine - https://web.archive.org/web/20210831162251/https://github.com/TheAlgorithms/Python/pull/4641
Skip to content
Sign up
Sign in
Sign up

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mypy] Fix type annotations for strings #4641

Merged
merged 3 commits into from Aug 25, 2021
Merged

[mypy] Fix type annotations for strings #4641

merged 3 commits into from Aug 25, 2021

Conversation

@imp2002
Copy link
Member

@imp2002 imp2002 commented Aug 20, 2021

Related issue #4052

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
imp2002 added 3 commits Aug 20, 2021
@imp2002
Fix mypy error for min_cost_string_conversion.py
1ef2d65
@imp2002
Fix mypy error for manacher.py
632a21d
@imp2002
Fix mypy error for aho_corasick.py
90a6257
@L3str4nge
L3str4nge approved these changes Aug 25, 2021
View changes
@L3str4nge L3str4nge merged commit 5e7eed6 into TheAlgorithms:master Aug 25, 2021
2 checks passed
2 checks passed
@github-actions
build
Details
@github-actions
pre-commit
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@L3str4nge L3str4nge

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@imp2002 @L3str4nge
Morty Proxy This is a proxified and sanitized view of the page, visit original site.