…(thomasbisignani) This PR was merged into the 2.8 branch. Discussion ---------- [Validator] Added the missing constraints instance checks | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR adds the constraints instance checks missing to limit the validators use. This behavior is already implemented in all built-in validators, but it was missed in two validators. Commits ------- 0ecaead [Validator] Added the missing constraints instance checks
This PR was merged into the 2.8 branch. Discussion ---------- [Form] Fixed empty data for compound date types | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #4715 | License | MIT | Doc PR | ~ Commits ------- 9bab1e8 [Form] Fixed empty data for compound date types
This PR was merged into the 2.8 branch. Discussion ---------- Command::addOption should allow int in $default | Q | A | ------------- | --- | Branch? | all | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> In #28714 the documentation for `$default` on `Command::addOption` was changed to specify more specifically than `mixed`. However, there is an inconsistency as `InputOption::__construct` allows int in its `$default`, but not `Command::addOption`. This PR makes fixes that inconsistency. Commits ------- 5f8bd89 Command::addOption should allow int in $default
This PR was merged into the 2.8 branch. Discussion ---------- [Form] Minor fixes in docs and cs | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- de40f5d [Form] Minor fixes in docs and cs
…ubmit (HeahDude) This PR was merged into the 2.8 branch. Discussion ---------- [Form] Fixed keeping hash of equal \DateTimeInterface on submit | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ Commits ------- bc2e2cb [Form] Fixed keeping hash of equal \DateTimeInterface on submit
The constructor for InputOption allows int on the $default parameter, but not Command::addOption $default parameter fixup: apply coding standards patch
This PR was merged into the 2.8 branch. Discussion ---------- [PhpUnitBridge] Fix typo | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- 78e386e [PhpUnitBridge] Fix typo
This PR was merged into the 2.8 branch. Discussion ---------- [Form] invalidate forms on transformation failures | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #20916, #21242, #28584 | License | MIT | Doc PR | Commits ------- 385d9df invalidate forms on transformation failures
This PR was squashed before being merged into the 2.8 branch (closes #29152). Discussion ---------- [Config] Unset key during normalization | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes-ish | New feature? | yes | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #29142 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> 2.8 vs. 4.x :) let me know. Commits ------- e1402d4 [Config] Unset key during normalization
This PR was merged into the 2.8 branch. Discussion ---------- Add required key attribute | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a I am getting warnings when running tests with recent phpunit versions (since 7.2.0) : > `- Element 'element': The attribute 'key' is required but missing.` This requirement is far from being new, what is recent is phpunit validating its configuration file against the XSD schema. See sebastianbergmann/phpunit@d4484be This is pedantic (not a bugfix), and might be a bit painful to merge upstream, so if you feel like I should target a more recent instead and let the old branches go on with their lives, please tell me. Commits ------- c0733c2 Add required key attribute
This PR was merged into the 2.8 branch. Discussion ---------- Bump phpunit XSD version to 5.2 | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a Some attributes being used in the phpunit configuration files, namely `failOnRisky` and `failOnWarning` were introduced in phpunit 5.2.0. The Composer configuration shows that tests should run with old versions of phpunit, but phpunit only validates the configuration against the XSD since phpunit 7.2.0 These changes can be tested as follows: ``` wget http://schema.phpunit.de/5.2/phpunit.xsd xargs xmllint --schema phpunit.xsd 1>/dev/null find src -name phpunit.xml.dist| xargs xmllint --schema phpunit.xsd 1>/dev/null ``` See sebastianbergmann/phpunit@7e06a82 See https://github.com/symfony/symfony/blob/46e3745a03e199e64cc0fcf3284a96b5a25dcee9/composer.json#L98 Commits ------- 4dce4b7 Bump phpunit XSD version to 5.2
This PR was merged into the 2.8 branch. Discussion ---------- [Form] Hardened test suite for empty data | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | # | License | MIT | Doc PR | ~ Finally the continuation of #21877, giving some more love to 2.8 before it is not maintained anymore <3. Commits ------- b0dab62 [Form] Hardened test suite for empty data
Some attributes being used in the phpunit configuration files, namely failOnRisky and failOnWarning were introduced in phpunit 5.2.0. The Composer configuration shows that tests should run with old versions of phpunit, but phpunit only validates the configuration against the XSD since phpunit 7.2.0. These changes can be tested as follows: wget http://schema.phpunit.de/5.2/phpunit.xsd xargs xmllint --schema phpunit.xsd 1>/dev/null find src -name phpunit.xml.dist| xargs xmllint --schema phpunit.xsd 1>/dev/null See sebastianbergmann/phpunit@7e06a82 See https://github.com/symfony/symfony/blob/46e3745a03e199e64cc0fcf3284a96b5a25dcee9/composer.json#L98
I am getting warnings when running tests with recent phpunit versions: > - Element 'element': The attribute 'key' is required but missing. This requirement is far from being new, what is recent is phpunit validating its configuration file against the XSD schema. See sebastianbergmann/phpunit@d4484be
…ers (nicolas-grekas) This PR was merged into the 2.8 branch. Discussion ---------- [HttpFoundation] replace any preexisting Content-Type headers | Q | A | ------------- | --- | Branch? | 2.8 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21204 | License | MIT | Doc PR | - Commits ------- de2ce58 [HttpFoundation] replace any preexisting Content-Type headers
…an (lyrixx) This PR was merged into the 2.8 branch. Discussion ---------- [HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | --- Since the method should return a bool, then the default value should be a bool too Commits ------- 1fa5a9a [HttpFoundation] Fixed PHP doc of ParameterBag::getBoolean
Since the method should return a bool, then the default value should be a bool too
…inaSt) This PR was squashed before being merged into the 2.8 branch (closes #29077). Discussion ---------- Add framework asset changes to upgrade 3.0 guide | Q | A | ------------- | --- | Branch? | 2.8 up to 4.1 <!-- see below --> | Bug fix? | no (upgrade guide improvement) | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #29050 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | - <!-- required for new features --> further reading: https://symfony.com/blog/new-in-symfony-2-7-the-new-asset-component <!-- Write a short README entry for your feature/bugfix here (replace this comment block.) This will help people understand your PR and can be used as a start of the Doc PR. Additionally: - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. --> Commits ------- 7de1088 Add framework asset changes to upgrade 3.0 guide
This PR was submitted for the 2.7 branch but it was merged into the 2.8 branch instead (closes #29099). Discussion ---------- [Travis] Bump ext-mongodb to 1.5.2 on Travis | Q | A | ------------- | --- | Branch? | 2.7 <!-- see below --> | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | https://travis-ci.org/symfony/symfony/jobs/451058906#L2679 <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Should fix Travis builds after mongodb/mongo-php-library@ba0b611 being merged (but not released yet). And/or use `composer require --dev --no-update mongodb/mongodb:@stable`? Commits ------- 6e4af32 [Travis] Bump ext-mongodb to 1.5.2 on Travis
