The Wayback Machine - https://web.archive.org/web/20221101020106/https://github.com/symfony/symfony/pull/42114
Skip to content
Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpFoundation] Fix return types of SessionHandler::gc() #42114

Merged
merged 1 commit into from Jul 15, 2021
Merged

[HttpFoundation] Fix return types of SessionHandler::gc() #42114

merged 1 commit into from Jul 15, 2021

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Jul 14, 2021

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets #41552
License MIT
Doc PR N/A

SessionHandler::gc() should return the number of garbage-collected sessions. We often return true which violates that contract.

@carsonbot carsonbot added this to the 4.4 milestone Jul 14, 2021
@derrabus derrabus force-pushed the bugfix/session-gc-return branch 4 times, most recently from 7737731 to 440ab14 Compare Jul 15, 2021
@derrabus
[HttpFoundation] Fix return types of SessionHandler::gc()
1261a41 
Signed-off-by: Alexander M. Turek <me@derrabus.de>
@derrabus derrabus force-pushed the bugfix/session-gc-return branch from 440ab14 to 1261a41 Compare Jul 15, 2021
@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jul 15, 2021

Thank you @derrabus.

@nicolas-grekas nicolas-grekas merged commit 6c8114a into symfony:4.4 Jul 15, 2021
9 of 10 checks passed
@derrabus derrabus deleted the bugfix/session-gc-return branch Jul 15, 2021
This was referenced Jul 26, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug HttpFoundation Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@derrabus @nicolas-grekas @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.