[Security] Implement fluent interface on RememberMeBadge::disable() #41787
Conversation
Signed-off-by: Alexander M. Turek <me@derrabus.de>
|
While I'm OK with merging, is there a real use-case for disable being fluent? I mean, The reason btw for |
|
I made this PR mainly to create a consistent behavior. The only use-case I can think of is a function that mutates and returns the badge, e.g. return $badge->disable();instead of $badge->disable();
return $badge; |
|
Makes sense! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
I was a bit puzzled when a I saw that
RememberMeBadge::enable()implements a fluent interface while its counterpartdisable()does not. This PR fixes this inconsistency.The class is flagged as
@final, so this change should not violate the BC promise.