The Wayback Machine - https://web.archive.org/web/20211123211353/https://github.com/symfony/symfony/pull/42323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TwigBridge] do not merge label classes into expanded choice labels #42323

Merged

fancyweb merged 1 commit into symfony:4.4 from xabbuh:issue-40005

Nov 19, 2021

+0 −9

Member

xabbuh commented Jul 30, 2021

Q	A
Branch?	4.4
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets	Fix #40005
License	MIT
Doc PR

xabbuh added this to the 4.4 milestone

carsonbot added Status: Needs Review Bug TwigBridge labels

xabbuh force-pushed the issue-40005 branch from 3491aea to a5879bc

xabbuh changed the title ~~[TwigBridge] do not merge label classes into choice labels~~ [TwigBridge] do not merge label classes into expanded choice labels

Member Author

xabbuh commented Jul 30, 2021

CI failure looks related

Status: Needs work

carsonbot added Status: Needs Work and removed Status: Needs Review labels

xabbuh force-pushed the issue-40005 branch 3 times, most recently from a0c4375 to 4ec3be7

Member Author

xabbuh commented Aug 16, 2021

After having another look I fail to see how the failure is related.

Status: Needs Review

carsonbot added Status: Needs Review and removed Status: Needs Work labels

carsonbot commented Aug 16, 2021

Hey!

I think @ker0x has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

Member Author

xabbuh commented Nov 13, 2021

ping @symfony/mergers

ogizanagi reviewed

src/Symfony/Bridge/Twig/Resources/views/Form/bootstrap_3_layout.html.twig Show resolved Hide resolved


          do not merge label classes into expanded choice labels

xabbuh force-pushed the issue-40005 branch from 4ec3be7 to 9400311

chalasr approved these changes

carsonbot added Status: Reviewed and removed Status: Needs Review labels

yceruto approved these changes

ogizanagi approved these changes

welcoMattic approved these changes

ogizanagi added the Ready label

derrabus approved these changes

Contributor

fancyweb commented Nov 19, 2021

Thank you @xabbuh.

fancyweb merged commit eee7b80 into symfony:4.4

9 of 10 checks passed

xabbuh deleted the issue-40005 branch

fabpot mentioned this pull request

Release v4.4.34 #44193

Merged

fabpot mentioned this pull request

Release v5.3.11 #44194

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment