The Wayback Machine - https://web.archive.org/web/20210729180246/https://github.com/symfony/symfony/pull/42322
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract deprecation channel from triggering file #42322

Open
wants to merge 3 commits into
base: 5.4
Choose a base branch
from

Conversation

@Toflar
Copy link
Contributor

@Toflar Toflar commented Jul 29, 2021

Q A
Branch? 5.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets
License MIT
Doc PR -

I think it would be great if deprecations were automatically channelled by their Composer package.
That way you can easily spot where the deprecation was triggered from and you can easily filter it thanks to @javiereguiluz's nice new interface (thank you, Javier!) :-)

It would look something like this:

Bildschirmfoto 2021-07-29 um 19 08 48

Just a quick POC without any tests etc. just to clarify if this would be an interesting addition to Symfony and if so, if using channels for that is even the correct approach.

@carsonbot
Copy link

@carsonbot carsonbot commented Jul 29, 2021

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.