FIX StandardScaler.inverse_transform raise error when the input is a 1d array #19752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Mar 29, 2021
Thanks for the PR. Could you please add a new test in sklearn/preprocessing/tests/test_data.py that checks the new behavior only for StandardScaler in isolation?
Please also add a new entry in doc/whats_new/v1.0.rst.
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
|
Hey guys, since the PR has been opened for a couple month, just checking if there is any other changes that I need to work on regarding this issue? |
thomasjpfan
approved these changes
Jun 19, 2021
Thank you for the ping @MaxwellLZH
I synced this PR with main and I think its ready to merge.
|
Thanks @MaxwellLZH |
TomDLT
added a commit
to TomDLT/scikit-learn
that referenced
this issue
Jul 29, 2021
…1d array (scikit-learn#19752) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin
added a commit
to samronsin/scikit-learn
that referenced
this issue
Nov 30, 2021
…1d array (scikit-learn#19752) Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com> Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reference Issues/PRs
This is a fix to issue #19518.
What does this implement/fix? Explain your changes.
Added check_array in
StandardScaler.inverse_transform, and fixed failing test cases.The text was updated successfully, but these errors were encountered: