cc @simonjayhawkins

are we not testing with the minimum setuptools?

are we not testing with the minimum setuptools?

No, we are not.

in doc/source/development/contributing_environment.rst

Creating a Python environment (pip)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

If you aren't using conda for your development environment, follow these instructions.
You'll need to have at least the :ref:`minimum Python version <install.version>` that pandas supports. If your Python version
is 3.8.0 (or later), you might need to update your ``setuptools`` to version 42.0.0 (or later)
in your development environment before installing the build dependencies::

can be updated.

can you update the min pin in environment.yaml (and other places if needed)?

also this should be added to the wheel recipe @simonjayhawkins (practically this already works, but should add)

test failure unrelated

E           AssertionError: Caused unexpected warning(s): [('ResourceWarning', ResourceWarning("unclosed <ssl.SSLSocket fd=8, family=AddressFamily.AF_INET, type=SocketKind.SOCK_STREAM, proto=6, laddr=('10.1.1.54', 48258), raddr=('52.217.136.144', 443)>"), '/home/runner/work/pandas/pandas/pandas/io/sas/sas7bdat.py', 381)]

can you update the min pin in environment.yaml (and other places if needed)?

@fangchenli can you address this

also this should be added to the wheel recipe @simonjayhawkins (practically this already works, but should add)

pandas-feedstock or MacPython or both?

can you update the min pin in environment.yaml (and other places if needed)?

We don't list setuptools in environment.yaml.

labelled as blocker as we won't be changing min versions of dependencies in patch releases?

yeah i think we should just add this to environment.yaml. it is technically only needed if we use matplotlib so its not a required dep (so only add it where we have matplotlib, which is most places).

conda-incubator/setup-miniconda@v2 does not seem to like the setuptools pin, although I think there have been conda-incubator/setup-miniconda@v2 timeouts on other PRs

The version in pandas-dev on CI / Checks for master (https://github.com/pandas-dev/pandas/runs/2950514145) is

2021-06-30T09:08:01.2373051Z setuptools                49.6.0           py38h578d9bd_3    conda-forge

and creating dev env locally

my backport env (1.3.x)

(pandas-backport) simon@ProDesk:~/pandas (backport-of-pr-42318-on-1.3.x)$ conda list setuptools
# packages in environment at /home/simon/miniconda3/envs/pandas-backport:
#
# Name                    Version                   Build  Channel
setuptools                49.6.0           py38h578d9bd_3    conda-forge

my master env

(pandas-dev) simon@P340:~/pandas (master)$ conda list setuptools
# packages in environment at /home/simon/miniconda3/envs/pandas-dev:
#
# Name                    Version                   Build  Channel
setuptools                49.6.0           py38h578d9bd_3    conda-forge

According to https://setuptools.readthedocs.io/en/latest/userguide/declarative_config.html, the min version of setuptools that support entry_points in setup.cfg is 51.0.0.

hmm? our tests pass locally?

@jreback ok to release without this PR, or delay release to allow time for others to look at this? @pandas-dev/pandas-core

should
include this

should
include this

it appears can't create a dev env with conda with this pin

Could leave it out of the yml file and then do a pip install -r requirements-dev.txt (assuming it is in requirements-dev.txt). This will no op everything that is installed, but upgrade setuptools if below.

should
include this

it appears can't create a dev env with conda with this pin

can create a dev env locally from scratch using this pin. so maybe something related to conda-incubator/setup-miniconda@v2

creating a dev env from scratch without this pin, the only diff is

< setuptools=49.6.0=py38h578d9bd_3
---
> setuptools=52.0.0=py38h06a4308_0

so it's a mystery to me how conda chooses the version.

hmm yeah this should just work.

not yet triaged the pypy failures on conda-forge https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=345935&view=results, but did notice setuptools was pre 0.51

moving to 1.3.2

thanks @fangchenli this is essentially a doc update at this point so backporting ok.

@meeseeksdev backport 1.3.x