The Wayback Machine - https://web.archive.org/web/20210705012534/https://github.com/symfony/symfony/pull/41739
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid broken action URL in text notification mail #41739

Merged
merged 1 commit into from Jun 23, 2021
Merged

Conversation

@mbrodala
Copy link
Contributor

@mbrodala mbrodala commented Jun 18, 2021

Q A
Branch? 5.3 for bug fixes
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

Some mail clients make URLs clickable automatically which leads to broken URLs due to the appended ":" (colon)

Fix this by moving the action text before the action URL.

@carsonbot carsonbot added this to the 5.3 milestone Jun 18, 2021
@mbrodala mbrodala changed the title Avoid broken action URL in text notification mail [TwigBridge] Avoid broken action URL in text notification mail Jun 18, 2021
@carsonbot carsonbot changed the title [TwigBridge] Avoid broken action URL in text notification mail Avoid broken action URL in text notification mail Jun 23, 2021
@fabpot
fabpot approved these changes Jun 23, 2021
Copy link
Member

@fabpot fabpot left a comment

for 5.2

Some mail clients make URLs clickable automatically which leads to broken URLs due to the appended ":" (colon)

Fix this by moving the action text before the action URL.
@fabpot fabpot changed the base branch from 5.3 to 5.2 Jun 23, 2021
@fabpot fabpot force-pushed the mbrodala:patch-2 branch from ffa3570 to 6f6e8cf Jun 23, 2021
@fabpot
Copy link
Member

@fabpot fabpot commented Jun 23, 2021

Thank you @mbrodala.

@fabpot fabpot merged commit e1b81e3 into symfony:5.2 Jun 23, 2021
4 of 5 checks passed
4 of 5 checks passed
@github-actions
Psalm
Details
@github-actions
Integration (7.2)
Details
@github-actions
Integration (8.0)
Details
@github-actions
PHPUnit on PHP nightly PHPUnit on PHP nightly
Details
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@mbrodala mbrodala deleted the mbrodala:patch-2 branch Jun 23, 2021
This was referenced Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.