The Wayback Machine - https://web.archive.org/web/20220807061212/https://github.com/symfony/symfony/pull/39795
Skip to content
Sign up
Sign in
Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont allow unserializing classes with a destructor - 5.1 #39795

Merged
merged 1 commit into from Jan 12, 2021
Merged

Dont allow unserializing classes with a destructor - 5.1 #39795

merged 1 commit into from Jan 12, 2021

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Jan 12, 2021

Q A
Branch? 5.1
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Prevent destructors with side-effects from being unserialized

@jderusse jderusse requested a review from sroze as a code owner Jan 12, 2021
@nicolas-grekas nicolas-grekas added this to the 5.1 milestone Jan 12, 2021
@nicolas-grekas nicolas-grekas changed the base branch from 5.x to 5.1 Jan 12, 2021
@nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jan 12, 2021

Thank you @jderusse.

@nicolas-grekas nicolas-grekas merged commit 8bc5679 into symfony:5.1 Jan 12, 2021
5 checks passed
@jderusse jderusse deleted the sec-destruct-51 branch Jan 12, 2021
This was referenced Jan 27, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas

@sroze sroze

Assignees
No one assigned
Labels
Bug Status: Reviewed
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jderusse @nicolas-grekas @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.