The Wayback Machine - https://web.archive.org/web/20220811041305/https://github.com/symfony/symfony/pull/39210
Skip to content
Sign up
Sign in
Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DoctrineBridge] Fix form EntityType with filter on UID #39210

Merged
merged 1 commit into from Nov 28, 2020
Merged

[DoctrineBridge] Fix form EntityType with filter on UID #39210

merged 1 commit into from Nov 28, 2020

Conversation

jderusse
Copy link
Member

@jderusse jderusse commented Nov 28, 2020

Q A
Branch? 5.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #39207
License MIT
Doc PR -

Convert UUID and ULID to the right format in ORMQueryBuilder

/cc @nicolas-grekas

@jderusse jderusse changed the base branch from 5.x to 5.2 Nov 28, 2020
@jderusse jderusse added this to the 5.2 milestone Nov 28, 2020
@jderusse jderusse changed the title [DoctrineBridge] Fix form EntotyType with uid [DoctrineBridge] Fix form EntityType with filter on UID Nov 28, 2020
nicolas-grekas
nicolas-grekas reviewed Nov 28, 2020
View changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

nice!
LGTM, once tests are green

src/Symfony/Bridge/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php Outdated Show resolved Hide resolved
nicolas-grekas
nicolas-grekas approved these changes Nov 28, 2020
View changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Thank you @jderusse

@nicolas-grekas nicolas-grekas merged commit 0c285d1 into symfony:5.2 Nov 28, 2020
3 of 5 checks passed
@colinodell
Copy link
Contributor

@colinodell colinodell commented Nov 28, 2020

Thanks for the quick fix!

@fabpot fabpot mentioned this pull request Nov 30, 2020
Merged
@jderusse jderusse deleted the uid-form branch Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-demb andrew-demb

@nicolas-grekas nicolas-grekas

Assignees
No one assigned
Labels
Bug DoctrineBridge Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

[DoctrineBridge] ORMQueryBuilderLoader not compatible with binary UUID columns
5 participants
@jderusse @colinodell @nicolas-grekas @andrew-demb @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.