[Config] Stop treating multiline resources as globs #39142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Dec 8, 2020
derrabus
approved these changes
Dec 8, 2020
xabbuh
approved these changes
Dec 9, 2020
|
Thank you @michaelKaefer. |
|
Thanks, Michael, that'll help us A LOT in @Sylius |
This was referenced Dec 9, 2020
This was referenced Dec 18, 2020
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Would fix the linked issue.
In #22938 it was suggested to enhance the glob-detection logic by detecting newlines.
Cons:
bar\nbaz*.txt) as a resource anymore - maybe in another edge case this is needed