The Wayback Machine - https://web.archive.org/web/20220811041352/https://github.com/symfony/symfony/pull/39128
Skip to content
Sign up
Sign in
Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpFoundation] Deprecate BinaryFileResponse::create() #39128

Merged
merged 1 commit into from Nov 27, 2020
Merged

[HttpFoundation] Deprecate BinaryFileResponse::create() #39128

merged 1 commit into from Nov 27, 2020

Conversation

derrabus
Copy link
Member

@derrabus derrabus commented Nov 20, 2020

Q A
Branch? 5.2
Bug fix? no
New feature? no
Deprecations? yes
Tickets N/A
License MIT
Doc PR N/A

Follows #34771. We've deprecated the static ::create() methods on all response classes but BinaryFileResponse. This PR proposes to fix this inconsistency.

@carsonbot carsonbot added this to the 5.2 milestone Nov 20, 2020
@derrabus derrabus force-pushed the improvement/deprecate-bfr-create branch from 2c3918f to 9ce2e86 Compare Nov 20, 2020
@derrabus
Copy link
Member Author

@derrabus derrabus commented Nov 20, 2020

Paging @fabpot: Was there a particular reason why BinaryFileResponse was omitted in #34771?

fabpot
fabpot approved these changes Nov 27, 2020
View changes
@fabpot
Copy link
Member

@fabpot fabpot commented Nov 27, 2020

Thank you @derrabus.

@fabpot fabpot mentioned this pull request Nov 27, 2020
Closed
@fabpot fabpot merged commit 7378b0b into symfony:5.2 Nov 27, 2020
3 of 5 checks passed
@derrabus derrabus deleted the improvement/deprecate-bfr-create branch Nov 27, 2020
@fabpot fabpot mentioned this pull request Nov 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot

@jderusse jderusse

Assignees
No one assigned
Labels
Deprecation HttpFoundation Status: Reviewed
Projects
None yet
Milestone
5.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@derrabus @fabpot @jderusse @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.