The Wayback Machine - https://web.archive.org/web/20201220220336/https://github.com/lodash/lodash/pull/4239
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak _.clone/_.cloneDeep docs #4239

Merged
merged 1 commit into from Mar 18, 2019
Merged

tweak _.clone/_.cloneDeep docs #4239

merged 1 commit into from Mar 18, 2019

Conversation

@dwelle
Copy link
Contributor

@dwelle dwelle commented Mar 15, 2019

Ad #4212.

Sorry for the delay. Also not sure whether to address the deprecated structured clone algo, so I just added note about copying the prototype.

@jsf-clabot
Copy link

@jsf-clabot jsf-clabot commented Mar 15, 2019

CLA assistant check
All committers have signed the CLA.

@jdalton
Copy link
Member

@jdalton jdalton commented Mar 15, 2019

Thanks @dwelle!

The sentence "Prototype is copied." feels kind of shoehorned in. Can you try to make it more conversational.

@dwelle
Copy link
Contributor Author

@dwelle dwelle commented Mar 16, 2019

@jdalton absolutely, but I have no clue what wording to choose. "Original prototype reference is kept" perhaps?

@jdalton
Copy link
Member

@jdalton jdalton commented Mar 16, 2019

You could say something like `"Object inheritance is preserved."

@dwelle dwelle force-pushed the dwelle:clone_docs branch from 561fffb to f60f78d Mar 17, 2019
@dwelle dwelle force-pushed the dwelle:clone_docs branch from f60f78d to ef0380f Mar 17, 2019
@dwelle
Copy link
Contributor Author

@dwelle dwelle commented Mar 17, 2019

Sounds good. Amended. Thanks for assistance.

@jdalton
Copy link
Member

@jdalton jdalton commented Mar 18, 2019

Thank you @dwelle!

@jdalton jdalton merged commit 750067f into lodash:master Mar 18, 2019
1 check passed
1 check passed
licence/cla Contributor License Agreement is signed.
Details
@lock
Copy link

@lock lock bot commented Mar 17, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Mar 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.