The Wayback Machine - https://web.archive.org/web/20201212155502/https://github.com/vuejs/vue-test-utils/pull/1699
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: treat document.body in attachTo in special way #1699

Merged
merged 1 commit into from Oct 1, 2020

Conversation

@xanf
Copy link
Contributor

@xanf xanf commented Sep 28, 2020

When using attachTo with document.body as a target do not replace original content of body but append a new div instead

See #1578 for details and discussion

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)
@xanf xanf force-pushed the xanf:xanf-add-document-body-behavior branch from 0ef42ee to 7d07d68 Sep 28, 2020
When using attachTo with document.body as a target do not replace
original content of body but append a new div instead

See #1578 for details and discussion
@xanf xanf force-pushed the xanf:xanf-add-document-body-behavior branch from 7d07d68 to 09a34dd Sep 28, 2020
Copy link
Member

@lmiller1990 lmiller1990 left a comment

Great, thanks!

@lmiller1990 lmiller1990 merged commit a821908 into vuejs:dev Oct 1, 2020
6 checks passed
6 checks passed
ci/circleci: bootstrap Your tests passed on CircleCI!
Details
ci/circleci: build_test Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test_compat Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.