The Wayback Machine - https://web.archive.org/web/20201125010830/https://github.com/TheAlgorithms/Python/pull/3754
Skip to content
Sign up
Sign in Sign up

/ Python

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Project Euler Readme #3754

Merged
merged 4 commits into from Oct 26, 2020
Merged

Fix Project Euler Readme #3754

merged 4 commits into from Oct 26, 2020

Conversation

@poyea
Copy link
Member

@poyea poyea commented Oct 26, 2020

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.
poyea and others added 3 commits Oct 26, 2020
@poyea
Fix Project Euler Readme
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
0902afd
github-actions github-actions
updating DIRECTORY.md
6583238
@poyea
Update CONTRIBUTING.md
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
edfcab2
@poyea poyea requested review from dhruvmanila and Kush1101 as code owners Oct 26, 2020
@poyea
spacing
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
28e3dc1
@poyea poyea requested a review from shellhub Oct 26, 2020
@dhruvmanila
dhruvmanila approved these changes Oct 26, 2020
View changes
Copy link
Member

@dhruvmanila dhruvmanila left a comment

LGTM!
@dhruvmanila dhruvmanila merged commit a5aef14 into master Oct 26, 2020
7 checks passed
7 checks passed
project-euler
Details
build
Details
pre-commit
Details
pre-commit
Details
validate-solutions
Details
Gitpod Open an online workspace in Gitpod
Details
Travis CI - Pull Request Build Passed
Details
@poyea poyea deleted the project-euler-readme-fix branch Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvmanila dhruvmanila

@shellhub shellhub

@Kush1101 Kush1101

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@poyea @dhruvmanila
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.