The Wayback Machine - https://web.archive.org/web/20201103052556/https://github.com/neovim/neovim/issues/12139
Skip to content
Sign up
Sign in Sign up

/ neovim

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX: ":edit *.js" should suggest :next #12139

Open
ChrisPenner opened this issue Apr 17, 2020 · 12 comments
Open

UX: ":edit *.js" should suggest :next #12139

ChrisPenner opened this issue Apr 17, 2020 · 12 comments
Labels
complexity:low editor enhancement good first issue hacktoberfest
Milestone
unplanned

Comments

@ChrisPenner
Copy link

@ChrisPenner ChrisPenner commented Apr 17, 2020 •
edited

Actual behaviour

When simply trying to edit some additional files I often type :e *.js or something similar; this almost ALWAYS results in E77: Too many file names.

Expected behaviour

It's pretty clear what the user wants in this situation; they want to open the files as buffers! I'm sure there are legacy reasons for this error, but it's a pretty poor experience these days that probably doesn't need to stick around. (at least with set hidden enabled)

I've learned I can run :next *.js which has the behaviour I want, but next is a pretty unintuitive name and I don't really see a reason to have more than one command for this functionality.

In the worst case, perhaps we could simply add a note saying Maybe you meant to use :next to the error message? It took a bit of digging to find that solution and I'd love it if others didn't need to do the same.

Thanks for all your work everyone!
@teto teto added the usage label Apr 18, 2020
@justinmk justinmk added the editor label Aug 30, 2020
@justinmk
Copy link
Member

@justinmk justinmk commented Aug 30, 2020

perhaps we could simply add a note saying Maybe you meant to use :next to the error message

That seems reasonable.

I don't think :edit should work like next , because then the "literal" case is not addressed, e.g. if you actually want a buffer with literaly * in the name.
@justinmk justinmk added this to the unplanned milestone Aug 30, 2020
@justinmk justinmk changed the title :edit should behave more like :next UX: ":edit *.js" should suggest :next Aug 30, 2020
@armhzjz
Copy link

@armhzjz armhzjz commented Aug 31, 2020

Hello. I want to take this issue.
Could you give me a hint on where to look to start working on this issue (i.e. a file name or module or any other reference that could bring me closer to a good start?
@justinmk
Copy link
Member

@justinmk justinmk commented Aug 31, 2020

do_exedit()
@armhzjz
Copy link

@armhzjz armhzjz commented Aug 31, 2020

Thank you very much @justinmk
@pta2002
Copy link

@pta2002 pta2002 commented Sep 25, 2020

Are you still interested in working on this @armhzjz? Since it's been 25 days and I haven't seen any [WIP] pull request. I'd be interested in doing this too if you've stopped working on the issue.
@armhzjz
Copy link

@armhzjz armhzjz commented Sep 25, 2020

Hello @pta2002. I was on vacations and came back this Wednesday (two days ago) - that's why you saw no movement here. But I am in deed interested still on this and currently working on this. Thanks for asking.
@pta2002
Copy link

@pta2002 pta2002 commented Sep 25, 2020

Alright, good luck!
armhzjz added a commit to armhzjz/neovim that referenced this issue Sep 29, 2020
@armhzjz
UX: ":edit *.js" should suggest :next neovim#12139
369ad5b
@armhzjz armhzjz mentioned this issue Sep 29, 2020
Open
@vigoux vigoux added the hacktoberfest label Oct 1, 2020
@ritwikchakraborty123
Copy link

@ritwikchakraborty123 ritwikchakraborty123 commented Oct 2, 2020

Hai I. Want to solve this issue
@armhzjz
Copy link

@armhzjz armhzjz commented Oct 2, 2020

Hello @ritwikchakraborty123,
Sorry but I am currently working on it.
@Lee-yeah-sign
Copy link

@Lee-yeah-sign Lee-yeah-sign commented Oct 8, 2020

okay
@keremgocen
Copy link

@keremgocen keremgocen commented Oct 11, 2020

any updates on this one?:)
@armhzjz
Copy link

@armhzjz armhzjz commented Oct 11, 2020

PR created. It seems it has big chances of being merged as long as I provide a test.
:)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
complexity:low editor enhancement good first issue hacktoberfest
Projects
None yet
Milestone
unplanned
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
10 participants
@keremgocen @teto @justinmk @ChrisPenner @pta2002 @armhzjz @vigoux @ritwikchakraborty123 @Lee-yeah-sign and others
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.