The Wayback Machine - https://web.archive.org/web/20201031142542/https://github.com/ananthakumaran/tide/pull/384
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave company-backends for the user to setup #384

Open

Conversation

@alanpearce
Copy link

@alanpearce alanpearce commented Jul 4, 2020

Loading tide.el has the side-effect of adding the completion backend to company-backends with no configuration option. The user may however not wish to use company-tide, or not have it as the first backend.

Other company packages do not mangle company-backends, instead documenting the code to add their backend, to allow the user to add the backends in their preferred order (examples: 1, 2, 3). I therefore propose this change to follow this convention.

@josteink
Copy link
Collaborator

@josteink josteink commented Jul 4, 2020

This will be a breaking change/upgrade for most tide-users, which (for me personally) makes it a no-go.

While I can't speak for the other contributors, but if you could come up with some suggestions for how we can eliminate this causing breaking changes, that would definitely increase the chance of this getting merged.

@ananthakumaran
Copy link
Owner

@ananthakumaran ananthakumaran commented Jul 6, 2020

company-mode/company-mode#923 (comment) from this comment, it seems like updating company-backends from third party package is not the correct approach. But unfortunately, as @josteink pointed out, this code has been there from the beginning and going to break nearly all the existing users' setup which I prefer not to do. We can't merge this PR unless we come up with a solution that doesn't break the existing setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.