The Wayback Machine - https://web.archive.org/web/20201019102651/https://github.com/TheAlgorithms/Python/issues/3096
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request closed without a given reason #3096

Open
ronnydw opened this issue Oct 9, 2020 · 2 comments
Open

Pull request closed without a given reason #3096

ronnydw opened this issue Oct 9, 2020 · 2 comments

Comments

@ronnydw
Copy link

@ronnydw ronnydw commented Oct 9, 2020

My pull request #3071 was closed without a given reason.
I don’t mind it being closed without merging but I would like to learn why.
After all learning is the main purpose of this repo, no?

@dhruvmanila
Copy link
Member

@dhruvmanila dhruvmanila commented Oct 9, 2020

The reason was given as the label invalid, as it was an extremely minor change which was not needed.

@ronnydw
Copy link
Author

@ronnydw ronnydw commented Oct 9, 2020

Ok, fine for me, but take into account:

  1. replacing list comprehension by generator expression is not always an "extremely" minor change, see https://www.python.org/dev/peps/pep-0289/. I could have reported a bug that the algorithm does not work on low-memory machines when n is large (Out of memory exception).
  2. If this was not clear I would at least expected a request/comment to clarify instead of closing the pull request without further notice
  3. where can we find an explanation of the label #invalid?

I would propose the following process improvement:
Create a guideline for administrators

  • every update should be encouraged, how little it the improvement might be. Stimulating learning is the main goal of this repo.
  • before merging or rejecting a pull request 2 admins have to approve (especially for admins who are new to the project)
  • every rejection should be accompanied by a comment explaining why the pull request was rejected
  • in case of doubt write a comment for the author and ask for further clarification
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.