Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign updocs: add `rm -rf node_modules/` to release docs #19180
Merged
+3
−3
Conversation
In the latest release, I was not able to build even after running `yarn` to refresh dependencies. Eventually, we tracked the issue down to `rm -rf node_modules/`. There may be some instances where this can be necessary to ensure clean builds.
f8b9a50
into
angular:master
15 checks passed
15 checks passed
ci/angular: merge status
All checks passed!
ci/angular: size
No size change against base branch.
cla/google
All necessary CLAs are signed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
In the latest release, I was not able to build even after running
yarnto refresh dependencies. Eventually, we trackedthe issue down to
rm -rf node_modules/. There may be some instances where this can be necessary to ensure cleanbuilds.
I opted to just include this change directly in the commands to be more clear that people saw it. If devs want to be lazy they can always skip that step, but they will hopefully at least see it and be reminded that if something doesn't work, they should at least try
rm -rf node_modules/.