The Wayback Machine - https://web.archive.org/web/20201211001351/https://github.com/github/backup-utils/pull/648
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building Docker image from git source #648

Open
wants to merge 4 commits into
base: master
from
Open

Conversation

@AhrazA
Copy link

@AhrazA AhrazA commented Sep 28, 2020

We ran into issues attempting to match the version of backup-utils with the version of GitHub Enterprise we were running. This is because the Dockerfile always pulls the version tagged as "stable", regardless of which version of the repo is checked out.

By building from the git source files, instead of downloading the current release tagged "stable", users will be able to easily select which version of the backup-utils they wish to build.

As it stands, the only way to specify a version would be to roll a custom Dockerfile that either builds from source, or pulls in a specific release tag from https://github.com/github/backup-utils/archive/.

@AhrazA
Copy link
Author

@AhrazA AhrazA commented Oct 15, 2020

Any updates regarding this?

Copy link
Member

@djdefi djdefi left a comment

Overall I think am ok with this approach, however two concerns come to mind:

  1. The image size will be a bit larger, and builds will take a bit longer as Git history will get sent to the build context
  2. This may change what folks using the Docker image are currently expecting to happen (i.e. run the stable branch).

cc: @github/backup-utils @github/ghes-infrastructure any thoughts?

@@ -1,2 +0,0 @@
*
!share/github-backup-utils/ghe-docker-init

This comment has been minimized.

@djdefi

djdefi Oct 16, 2020
Member

I think we could just delete this entire file.

@AhrazA
Copy link
Author

@AhrazA AhrazA commented Oct 18, 2020

Thank you for the reply @djdefi

I made some changes that address your first comment. Also applied the same patch to the alpine Dockerfile.

Any guidance on why the macOS test might be failing? I spent some time trying to figure it out to no avail.

@AhrazA
Copy link
Author

@AhrazA AhrazA commented Nov 3, 2020

Pinging here again to keep this alive.

@AhrazA AhrazA requested a review from djdefi Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.