The Wayback Machine - https://web.archive.org/web/20201016235152/https://github.com/vuejs/eslint-plugin-vue/pull/1330
Skip to content
Sign up
Sign in Sign up

/ eslint-plugin-vue

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add allowModifiers option to valid-v-slot #1330

Open
wants to merge 5 commits into
base: master
from
Open

Add allowModifiers option to valid-v-slot #1330

wants to merge 5 commits into from

Conversation

@nokazn
Copy link

@nokazn nokazn commented Oct 11, 2020 •
edited

About

Add allowModifiers option to valid-v-slot rules. When this option is set to true, modifiers in the argument of v-slot are ignored, and invalid modifiers like v-slot.foo are still disallowed.
nokazn added 2 commits Oct 11, 2020
@nokazn
add allowModifiers option to valid-v-slot
9736e03
@nokazn
update doc
Loading status checks…
168dddb
@nokazn nokazn changed the title Add addModifiers option to valid-v-slot Add allowModifiers option to valid-v-slot Oct 11, 2020
@ota-meshi
ota-meshi requested changes Oct 11, 2020
View changes
Copy link
Member

@ota-meshi ota-meshi left a comment

Thank you for this PR!
I have some change requests.
tests/lib/rules/valid-v-slot.js Outdated Show resolved Hide resolved
tests/lib/rules/valid-v-slot.js Outdated Show resolved Hide resolved
lib/rules/valid-v-slot.js Outdated Show resolved Hide resolved
lib/rules/valid-v-slot.js Outdated Show resolved Hide resolved
tests/lib/rules/valid-v-slot.js Show resolved Hide resolved
nokazn added 2 commits Oct 11, 2020
@nokazn
fix for missing cases & improve code
fb137aa
@nokazn
add test cases
Loading status checks…
7b71243
@nokazn nokazn requested a review from ota-meshi Oct 11, 2020
@ota-meshi
ota-meshi requested changes Oct 11, 2020
View changes
tests/lib/rules/valid-v-slot.js Outdated Show resolved Hide resolved
@nokazn
revert option in test
Loading status checks…
902717b
@ota-meshi
ota-meshi approved these changes Oct 11, 2020
View changes
Copy link
Member

@ota-meshi ota-meshi left a comment

LGTM! Thank you!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ota-meshi ota-meshi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

valid-v-slot reporting errors on code that works
2 participants
@nokazn @ota-meshi
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.