The Wayback Machine - https://web.archive.org/web/20201016233211/https://github.com/vuejs/eslint-plugin-vue/pull/1102
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Add `vue/require-shorthand-boolean-prop` rule #1102

Open
wants to merge 1 commit into
base: master
from

Conversation

@inker
Copy link

@inker inker commented Apr 19, 2020

This PR adds the vue/require-shorthand-boolean-prop rule.

ref #775

@inker inker force-pushed the inker:master branch from 8f2adf9 to 815128e Apr 20, 2020
@inker inker force-pushed the inker:master branch from 815128e to 6d8a2fb Apr 20, 2020
@ota-meshi
Copy link
Member

@ota-meshi ota-meshi commented May 9, 2020

Thank you for this PR.

Due to the props definition of the used component, :isValid="true" and isValid are not equivalent.
I don't think this rule can report errors correctly.

What do you think?

@inker
Copy link
Author

@inker inker commented May 19, 2020

Due to the props definition of the used component, :isValid="true" and isValid are not equivalent.

I see what you mean. Currently, it only works for boolean props. Will investigate if it's possible to do prop type checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.