The Wayback Machine - https://web.archive.org/web/20201209184103/https://github.com/vuejs/vue/pull/11706
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): inheritAttrs false adds attributes to html (fix #11297) #11706

Open
wants to merge 2 commits into
base: dev
from

Conversation

@noreff
Copy link

@noreff noreff commented Oct 5, 2020

Fix 11297.

After this fix inheritAttrs option works in a correct way and don't add attributes to html output.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@noreff noreff changed the title fix(ssr): inheritAttrs false adds attributes to html fix(ssr): inheritAttrs false adds attributes to html (fix #11297) Oct 5, 2020
@noreff
Copy link
Author

@noreff noreff commented Oct 5, 2020

Not sure what is the reason behind ci/circleci: test-cover shows me 1 broken test in completely unrelated area. Locally I have 0 errors after running npm run test

@noreff
Copy link
Author

@noreff noreff commented Oct 6, 2020

I made a little research about ci/circleci: test-cover failing, while local tests was passing. I found out that it did already happen before with a same test that is now failing for me. @posva wrote back than that it could be indeed failing because of a random thing and I have a filling that it does. I think that should be investigated further and be fixed. I can work on it, but I would be glad if some one verified first that it's needed.

@vhoyer
vhoyer approved these changes Nov 10, 2020
Copy link

@vhoyer vhoyer left a comment

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.