The Wayback Machine - https://web.archive.org/web/20200916230452/https://github.com/github/maven-plugins/pull/71
Skip to content
Sign in Sign up

/ maven-plugins

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#69 fixed #71

Closed
wants to merge 1 commit into from
Closed

#69 fixed #71

wants to merge 1 commit into from

Conversation

@yegor256
Copy link

yegor256 commented Aug 31, 2014

Works for me, deploys the site without any issues
@yegor256
#69 fixed
Loading status checks…
d502ffe
@yegor256 yegor256 mentioned this pull request Aug 31, 2014
Closed
github-site-plugin/src/main/java/com/github/maven/plugins/site/SiteMojo.java
private CommitUser createCommitUser() {
CommitUser user = new CommitUser();
user.setName("site-maven-plugin");
user.setEmail("support@github.com");

This comment has been minimized.

Sign in to view
@mprins

mprins Aug 31, 2014 Contributor

❓ so all commits are going to show up as a different user than the one running the commit... really not a good idea AFAIC

These values should be set to the ones configured for the repository in the local git config or fallback to the global git config

This comment has been minimized.

Sign in to view
@yegor256

yegor256 Aug 31, 2014 Author

Ideally yes, but at the moment the plugin doesn't work at all. Version 0.9 is broken and nobody can use it. Would be great if we can merge this temporary fix and release version 0.9.1. Then, we can think about making it fully configurable, etc. What do you think?

This comment has been minimized.

Sign in to view
@mprins

mprins Aug 31, 2014 Contributor

I've been unable to find the egit api docs; but I don't see why it should bypass the local git configuration stored in .git/config or the global config in the users home directory

I have several user accounts that I work with for different clients (so even using the {user.name} provided by maven is not an option); this doesn't fix the problem for me.

This comment has been minimized.

Sign in to view
@adamcin

adamcin Aug 31, 2014 Contributor

@mprins @yegor256 I've just submitted a another pull request (#72) which similarly creates a CommitUser from the current github user's name and email address, which are provided by the EGit github UserService.
@cescoffier
Copy link
Collaborator

cescoffier commented Sep 1, 2014

So #72 should be merged instead of the other PR. Am I right ?
@yegor256
Copy link
Author

yegor256 commented Sep 1, 2014

@cescoffier fine for me, #72 should also work. please merge it and deploy a new version to Maven Central
@mprins
Copy link
Contributor

mprins commented Sep 1, 2014

+1 for #72
@mprins mprins mentioned this pull request Oct 31, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@yegor256 @cescoffier @mprins @adamcin
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.