The Wayback Machine - https://web.archive.org/web/20200908010628/https://github.com/scala-js/scala-js/pull/4178
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4174: Do not link to a non-existent source map in fullOptJS. #4178

Merged

Conversation

@sjrd
Copy link
Member

sjrd commented Sep 7, 2020

The fix is straightforward, but it is not tested. I am not sure how to test this specific behavior.

@sjrd sjrd requested a review from gzm0 Sep 7, 2020
@gzm0
gzm0 approved these changes Sep 7, 2020
The fix is straightforward, but it is not tested. I am not sure how
to test this specific behavior.
@sjrd sjrd force-pushed the sjrd:no-sourcemapuri-if-no-source-map-in-fulloptjs branch from a0c14b3 to 9939901 Sep 7, 2020
@sjrd sjrd merged commit a213dd9 into scala-js:master Sep 7, 2020
3 checks passed
3 checks passed
check
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@sjrd sjrd deleted the sjrd:no-sourcemapuri-if-no-source-map-in-fulloptjs branch Sep 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.