Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExtract a few tests with Arrays of Null and Nothing as Scala 2.x-only. #4181
+62
−31
Conversation
It was in `RuntimeTypesTest`, but it really only tests `ClassTag`s, so it should always have been in `ClassTagTest`. Since `ClassTag[Null]` is not supported by dotty, this commit moves it to `ClassTagTestScala2` instead.
As of this writing, the tests that were moved *can* be made to work by actively avoiding the `ClassTag`s, but they might break at any point in the future, because the status of `Array[Null]` and `Array[Nothing]` themselves in Scala 3 is up in the air.
ccd9ccd
to
8f3610e
| // Was `val arr = Array.fill[Null](5, 5)(null)` but that crashes on the JVM | ||
| val arr = new Array[Array[Null]](5) |
Comment on lines
+43
to
+44
This comment has been minimized.
This comment has been minimized.
sjrd
Sep 7, 2020
Author
Member
@gzm0 I had to adapt this to make testSuiteJVM pass. Previously those tests were in js/ only. It doesn't change the nature of what was being tested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
sjrd commentedSep 7, 2020
As of this writing, the tests that were moved can be made to work by actively avoiding the
ClassTags, but they might break at any point in the future, because the status ofArray[Null]andArray[Nothing]themselves in Scala 3 is up in the air.