This repository was archived by the owner on Jan 5, 2023. It is now read-only.
Add support for build tracing #178
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauyon
commented
Jun 12, 2020
| i++ | ||
| } | ||
| case "-i": | ||
| case "-p", "-asmflags", "-buildmode", "-compiler", "-gccgoflags", "-gcflags", "-installsuffix", |
There was a problem hiding this comment.
How did you come up with this list, and how do we maintain it going forward?
I used the documentation from go help build. Unfortunately I think we'll have to maintain it manually as there are new releases.
| if i+1 < len(args) { | ||
| i++ | ||
| } | ||
| case "-i": |
There was a problem hiding this comment.
It looks like
-iisn't actually skipped?
It is, as it's not added to the build flags list. I could put a continue here to make it more clear, though?
4d79db5 to
e454bc8
Compare
|
The fix for the MacOS issues has been merged; should I started testing on OS X again? |
|
Yes, please. I've not yet been able to find time to look at this again, I'm afraid. |
|
I take it this is superseded by #324? |
|
Ah, right. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c.f. #170