The Wayback Machine - https://web.archive.org/web/20200721012157/https://github.com/vuejs/docs-next/pull/181
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature (#169): add migration badges #181

Open
wants to merge 2 commits into
base: master
from

Conversation

@bencodezen
Copy link
Member

bencodezen commented Jul 15, 2020

Netlify Preview

Still not sure about the full list of what we want to include and how to tag things appropriately.

Maybe the badges should only be used next to the bulleted items in each overview section? That way it doesn't seem like the entire thing is broken or that an entire feature is removed?

Also, styles are totally up for feedback / changes. Just iterating along the way!

Closes #169

Copy link
Collaborator

NataliaTepluhina left a comment

@bencodezen just my chaotic thoughs

  • badges look cool! I'm not sure about the placement - should it be above title, inline or under
  • core, directives etc is a bit confusing to me as tbh as it's hard to define the finite list of such categories
  • AsyncComponents are breaking too! (current async imports will stop working)
@bencodezen
Copy link
Member Author

bencodezen commented Jul 15, 2020

@bencodezen just my chaotic thoughs

  • badges look cool! I'm not sure about the placement - should it be above title, inline or under
  • core, directives etc is a bit confusing to me as tbh as it's hard to define the finite list of such categories
  • AsyncComponents are breaking too! (current async imports will stop working)

Yeah I was trying to use the labels that were in the RFCs repo, but I don't think it makes sense to use what's in there. For now, maybe we can start with the following generic badges:

  • Breaking
  • Removal
  • Updated*
  • I debated "Major Changes" vs "Minor Changes," but this might be subjective and so I went with something more generic
@phanan
Copy link
Member

phanan commented Jul 17, 2020

The Netlify preview is gone for some reason. @bencodezen maybe a rebuild?

@sdras
sdras approved these changes Jul 19, 2020
Copy link
Member

sdras left a comment

These changes make a lot of sense to me, I didn't see anything breaking about your PR about breaking, haha

@sdras
Copy link
Member

sdras commented Jul 19, 2020

Looks like there are some merge conflicts and then we're good to go, @bencodezen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.