[FrameworkBundle] set default session.handler alias if handler_id is not provided #37572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jul 22, 2020
| @@ -463,6 +463,7 @@ public function testNullSessionHandler() | ||
| $this->assertTrue($container->hasDefinition('session'), '->registerSessionConfiguration() loads session.xml'); | ||
| $this->assertNull($container->getDefinition('session.storage.native')->getArgument(1)); | ||
| $this->assertNull($container->getDefinition('session.storage.php_bridge')->getArgument(0)); | ||
| $this->assertEquals('session.handler.native_file', (string) $container->getAlias('session.handler')); |
fabpot
approved these changes
Jul 23, 2020
|
Thank you @ybenhssaien. |
This was referenced Jul 24, 2020
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Without a configured
handler_id, thesession.handleralias is not created, and somes services depend on this alias specialy.Related to the reported issue above (affected version 4.4.9), the
ServiceHandlerInterfaceis an alias ofsession.handler, when execute :bin/console debug:container session.handler: The alias is not defined, so theContainerDebugCommandlook for a service containing thesession.handleras part of his name (ContainerDebugCommand::findServiceIdsContaining() is called and returns by defaultsession.handler.native_file)bin/console debug:container SessionHandlerInterface: The service is defined as an alias ofsession.handler, when callingContainerBuilder::getDefinition('session.handler')the exception occured as the alias is not defined.Implemented solution
Create a default
session.handlerwhen the paramhandler_idis not provided (I choosedsession.handler.native_filerather thanNullSessionHandler).Affected versions
From
3.4to5.1