The Wayback Machine - https://web.archive.org/web/20200627234524/https://github.com/angular/angular/pull/37624
Skip to content
Sign in Sign up

/ angular

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: move shims_for_IE to third_party directory #37624

Closed
wants to merge 1 commit into from
Closed

build: move shims_for_IE to third_party directory #37624

wants to merge 1 commit into from

Conversation

@josephperrott
Copy link
Member

josephperrott commented Jun 17, 2020

The shims_for_IE.js file contains vendor code that predates the third_party
directory. This file is currently used for internal karma testing setup. This
change corrects this by moving the shims_for_IE file to //third_part/

Closes #37615
@ngbot ngbot bot modified the milestone: needsTriage Jun 17, 2020
@googlebot googlebot added the cla: yes label Jun 17, 2020
@pullapprove pullapprove bot requested a review from atscott Jun 17, 2020
@josephperrott
build: move shims_for_IE to third_party directory
Loading status checks…
551fe85 
The shims_for_IE.js file contains vendor code that predates the third_party
directory. This file is currently used for internal karma testing setup. This
change corrects this by moving the shims_for_IE file to //third_part/
@josephperrott josephperrott force-pushed the josephperrott:shims-to-third-party branch from 6d01551 to 551fe85 Jun 17, 2020
@atscott
atscott approved these changes Jun 17, 2020
View changes
@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Jun 25, 2020

Hi @josephperrott, I just did a quick search in Google's codebase and found a few references. It looks like this file was excluded from the sync and since the location of the file has changed, it looks like it will be included. Could you please have a quick look at g3 and let me know if there is a patch CL we should land alongside with this change? I'm adding a "cleanup" label for now. Thank you.
@josephperrott
Copy link
Member Author

josephperrott commented Jun 26, 2020

@AndrewKushnir confirmed we are good to land as is. The references found in google3 are actually to the shims_for_IE.js file from AngularJS. This file was not synced into google previously and its new location in /third_party also will not be synced in.

The karma.conf.js file that is synced into google that changed is unreferenced.
@josephperrott josephperrott removed their assignment Jun 26, 2020
AndrewKushnir added a commit that referenced this pull request Jun 26, 2020
@josephperrott @AndrewKushnir
build: move shims_for_IE to third_party directory (#37624)
Loading status checks…
7f93f7e 
The shims_for_IE.js file contains vendor code that predates the third_party
directory. This file is currently used for internal karma testing setup. This
change corrects this by moving the shims_for_IE file to //third_part/

PR Close #37624
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atscott atscott

Assignees
No one assigned
Labels
PR action: merge PR target: master & patch cla: yes comp: build & ci
Projects
None yet
Milestone
  needsTriage
Linked issues

Successfully merging this pull request may close these issues.

Move code in shims_for_IE.js to third_party directory
4 participants
@josephperrott @AndrewKushnir @atscott @googlebot
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.