The Wayback Machine - https://web.archive.org/web/20201102194129/https://github.com/vuejs/vue-class-component/pull/423
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mark as side effect free to enable efficient tree-shaking #423

Merged
merged 1 commit into from May 6, 2020

Conversation

@ktsn
Copy link
Member

@ktsn ktsn commented May 6, 2020

Adding sideEffects: false helps webpack to tree-shake the user code includes vue-class-component.
https://webpack.js.org/guides/tree-shaking/#mark-the-file-as-side-effect-free

@ktsn ktsn merged commit 70ed762 into master May 6, 2020
10 checks passed
10 checks passed
Header rules No header rules processed
Details
Pages changed 27 new files uploaded
Details
Redirect rules No redirect rules processed
Details
Mixed content No mixed content detected
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: example-build Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details
@ktsn ktsn deleted the side-effect branch May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.