The Wayback Machine - https://web.archive.org/web/20220322220337/https://github.com/nodejs/node/pull/33596
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events: variable originalListener is useless #33596

Closed
wants to merge 1 commit into from
Closed

events: variable originalListener is useless #33596

wants to merge 1 commit into from

Conversation

fuxingZhang
Copy link
Contributor

@fuxingZhang fuxingZhang commented May 28, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Current tests are sufficient, no new tests are required

@nodejs-github-bot nodejs-github-bot added the events label May 28, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 28, 2020

Copy link
Member

@bnoordhuis bnoordhuis left a comment

It's tautologically true so good catch. :-)

ZYSzys
ZYSzys approved these changes May 28, 2020
@BridgeAR BridgeAR added the author ready label May 28, 2020
@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 30, 2020

jasnell added a commit that referenced this issue May 30, 2020
PR-URL: #33596
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

@jasnell jasnell commented May 30, 2020

Landed in c45f881

@jasnell jasnell closed this May 30, 2020
codebytere added a commit that referenced this issue Jun 18, 2020
PR-URL: #33596
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
codebytere added a commit that referenced this issue Jun 30, 2020
PR-URL: #33596
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit that referenced this issue Sep 22, 2020
PR-URL: #33596
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready events
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.