The Wayback Machine - https://web.archive.org/web/20220322220336/https://github.com/nodejs/node/pull/33592
Skip to content
Sign up
Sign in
Sign up
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: don't use semicolon outside function #33592

Closed
wants to merge 1 commit into from
Closed

src: don't use semicolon outside function #33592

wants to merge 1 commit into from

Conversation

codebytere
Copy link
Member

@codebytere codebytere commented May 27, 2020

This causes a build error in Electron:

../../third_party/electron_node/src/node_watchdog.cc:435:73: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]
NODE_MODULE_CONTEXT_AWARE_INTERNAL(watchdog, node::watchdog::Initialize);
                                                                        ^
1 error generated.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@codebytere codebytere requested a review from legendecas May 27, 2020
@nodejs-github-bot nodejs-github-bot added the c++ label May 27, 2020
mhdawson
mhdawson approved these changes May 27, 2020
View changes
Copy link
Member

@mhdawson mhdawson left a comment

LGTM

@nodejs-github-bot
Copy link
Contributor

@nodejs-github-bot nodejs-github-bot commented May 27, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31586/

@BridgeAR BridgeAR added the author ready label May 27, 2020
@codebytere
Copy link
Member Author

@codebytere codebytere commented May 28, 2020

This might be the most absurd PR i've raised so far 😆

@codebytere
Copy link
Member Author

@codebytere codebytere commented May 29, 2020

Landed in 0ff3819

@codebytere codebytere closed this May 29, 2020
codebytere added a commit that referenced this issue May 29, 2020
@codebytere
src: don't use semicolon outside function
0ff3819 
PR-URL: #33592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere deleted the no-semi branch May 29, 2020
codebytere added a commit that referenced this issue Jun 18, 2020
@codebytere
src: don't use semicolon outside function
522fbbc 
PR-URL: #33592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere added a commit that referenced this issue Jun 30, 2020
@codebytere
src: don't use semicolon outside function
0e7d26c 
PR-URL: #33592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere added a commit that referenced this issue Jul 8, 2020
@codebytere
src: don't use semicolon outside function
9c69296 
PR-URL: #33592
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere added a commit to electron/electron that referenced this issue Jul 23, 2020
@codebytere
src: don't use semicolon outside function
63b5950 
nodejs/node#33592
codebytere added a commit to electron/electron that referenced this issue Jul 24, 2020
@codebytere
src: don't use semicolon outside function
59fcb1a 
nodejs/node#33592
codebytere added a commit to electron/electron that referenced this issue Jul 24, 2020
@codebytere
src: don't use semicolon outside function
bc98d4e 
nodejs/node#33592
codebytere added a commit to electron/electron that referenced this issue Jul 24, 2020
@codebytere
src: don't use semicolon outside function
206d62b 
nodejs/node#33592
@snyk-bot snyk-bot mentioned this pull request Jan 25, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 25, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 25, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 25, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 25, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 25, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jan 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell

@addaleax addaleax

@benjamingr benjamingr

@mmarchini mmarchini

@richardlau richardlau

@MarshallOfSound MarshallOfSound

@legendecas legendecas

@BridgeAR BridgeAR

@mhdawson mhdawson

@Himself65 Himself65

@juanarbol juanarbol

Assignees
No one assigned
Labels
author ready c++
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
Morty Proxy This is a proxified and sanitized view of the page, visit original site.