The Wayback Machine - https://web.archive.org/web/20210124071533/https://github.com/webdevops/Dockerfile/issues/265
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate bin/console to Python 3 (and Pipenv) #265

Open
bittner opened this issue Aug 28, 2018 · 2 comments
Open

Migrate bin/console to Python 3 (and Pipenv) #265

bittner opened this issue Aug 28, 2018 · 2 comments

Comments

@bittner
Copy link

@bittner bittner commented Aug 28, 2018

The console script used in make provision runs on Python 2 only. As Python 2.7 is now deprecated and migrating to Python 3 is recommended it should be migrated to Python 3.6+.

While at it, it may make sense to add a Pipfile using pipenv, which is about to become the new standard of adding Python package and project requirements (obsoleting requirements.txt in future).

In addition, the code may be made more pythonic. Running flake8, and optionally Pylint, over the code base will suffice to detect what needs to be changed.

@bittner
Copy link
Author

@bittner bittner commented Aug 28, 2018

Side note: Having bin/console is a bit PHP-like. 😏 😄

@hhoechtl
Copy link
Member

@hhoechtl hhoechtl commented Aug 29, 2018

I haven't done python since over 10 years. But I would be very happy and thankful for a contribution ;-).
Our python familiar contributors are currently not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.