Plain 2FA password input #328

RadRussianRus · Oct 21, 2019

When entering 2FA password it is shown in plain text. This is because it uses input:

Lines 711 to 712 in 945bc61

    
           if not self.password: 
        
               self.password = input("Enter password (empty to recover): ")

I suggest to replacing it with with getpass.getpass().

zeroone2numeral2 · Oct 22, 2019

iirc getpass was causing some login issues when using pyrogram from Windows or some specific terminals, see this and this discussions in the chat

delivrance · Oct 22, 2019

Also, I'm not aware of any way of making getpass async.

RadRussianRus · Oct 23, 2019

It uses on login, and manual login process (where this is used) is not async anyway. Or I'm missing something?

Though problems on other terminals is more serious. I'd suggest to use escape codes, but I think problems will be the same.

pyrogram / pyrogram