The Wayback Machine - https://web.archive.org/web/20200908025935/https://github.com/scala-js/scala-js/pull/3703
Skip to content
Sign in Sign up

/ scala-js

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Scala 2.13.0 in the linker and all the other artifacts. #3703

Merged
merged 2 commits into from Jun 24, 2019
Merged

Enable Scala 2.13.0 in the linker and all the other artifacts. #3703

merged 2 commits into from Jun 24, 2019

Conversation

@sjrd
Copy link
Member

sjrd commented Jun 18, 2019

This is the equivalent of #3702 for the master branch.
@sjrd sjrd requested a review from gzm0 Jun 18, 2019
@sjrd
Fix an erroneous comparison of `RefinedType` with `Type`.
21729f3 
Discovered by new warnings emitted by the 2.13.0 compiler, yeah!
@sjrd sjrd force-pushed the sjrd:linker-on-scala-2.13.0 branch 2 times, most recently from e8d8109 to 8d777ce Jun 18, 2019
@sjrd
Copy link
Member Author

sjrd commented Jun 19, 2019

Updated to match recent changes in #3702.
@sjrd sjrd mentioned this pull request Jun 20, 2019
Closed
11 of 11 tasks complete
@sjrd
Enable Scala 2.13.0 in the linker and all the other artifacts.
Loading status checks…
1ba6ba8 
Partest is not yet enabled in this commit, because a dependency of
`partest` 2.13.0, namely `testkit`, was not published. See
scala/bug#11529 upstream.
@sjrd sjrd force-pushed the sjrd:linker-on-scala-2.13.0 branch from 8d777ce to 1ba6ba8 Jun 20, 2019
@gzm0
gzm0 reviewed Jun 20, 2019
View changes
scala-test-suite/src/test/resources/2.13.0/BlacklistedTests.txt

# Bugs
scala/collection/convert/MapWrapperTest.scala
# Fails for a BigDecimal range with augmented precision (might be an actual bug)

This comment has been minimized.

Sign in to view
@gzm0

gzm0 Jun 20, 2019

Contributor

Same comment: Is this actually a bug?

This comment has been minimized.

Sign in to view
@sjrd

sjrd Jun 21, 2019

Author Member

Filed as #3706.
@sjrd sjrd requested a review from gzm0 Jun 21, 2019
@sjrd
Copy link
Member Author

sjrd commented Jun 24, 2019

Ping @gzm0. If possible I'd like to merge this before the open source spree of Scala Matsuri, happening on Thursday.
@gzm0
gzm0 approved these changes Jun 24, 2019
View changes
@gzm0 gzm0 merged commit 1d96d3c into scala-js:master Jun 24, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
@sjrd sjrd deleted the sjrd:linker-on-scala-2.13.0 branch Jun 24, 2019
@sjrd
Copy link
Member Author

sjrd commented Jun 24, 2019

Thanks :)
@SethTisue SethTisue mentioned this pull request Jul 8, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gzm0 gzm0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@sjrd @gzm0
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.