Perfect your code
With built-in code review tools, GitHub makes it easy to raise the quality bar before you ship. Join the 36 million developers who've merged over 200 million pull requests.
Sign up for free See pricing for teams and enterprises[MRG] Configures Appveyor to fail fast after sklearn installation #13226
+7
−0
Conversation
jnothman
approved these changes
Feb 23, 2019
|
Happy to give it a go |
jnothman
merged commit cbc077a
into
scikit-learn:master
Feb 23, 2019
18 checks passed
LGTM analysis: C/C++
No code changes detected
Details
LGTM analysis: JavaScript
No code changes detected
Details
LGTM analysis: Python
No code changes detected
Details
ci/circleci: deploy
Your tests passed on CircleCI!
Details
ci/circleci: doc
Your tests passed on CircleCI!
Details
ci/circleci: doc-min-dependencies
Your tests passed on CircleCI!
Details
ci/circleci: lint
Your tests passed on CircleCI!
Details
codecov/patch
Coverage not affected when comparing 2480368...de90867
Details
codecov/project
92.48% (-0.01%) compared to 2480368
Details
continuous-integration/appveyor/pr
AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
scikit-learn.scikit-learn
Build #20190222.24 succeeded
Details
scikit-learn.scikit-learn (Linux py35_conda_openblas)
Linux py35_conda_openblas succeeded
Details
scikit-learn.scikit-learn (Linux py35_np_atlas)
Linux py35_np_atlas succeeded
Details
scikit-learn.scikit-learn (Linux pylatest_conda)
Linux pylatest_conda succeeded
Details
scikit-learn.scikit-learn (Windows py35)
Windows py35 succeeded
Details
scikit-learn.scikit-learn (Windows py37)
Windows py37 succeeded
Details
scikit-learn.scikit-learn (macOS pylatest_conda)
macOS pylatest_conda succeeded
Details
xhlulu
added a commit
to xhlulu/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhlulu
added a commit
to xhlulu/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhlulu
added a commit
to xhlulu/scikit-learn
that referenced
this pull request
Apr 28, 2019
koenvandevelde
added a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.


thomasjpfan commentedFeb 22, 2019
This PR configures Appveyor check for a newer build after sklearn installation and cancel the current build if a newer build exists.