Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDefine the arguments of reduce’s callback function #71
Conversation
| @@ -6684,15 +6684,15 @@ | ||
| [x] (instance? java.util.UUID x)) | ||
|
|
||
| (defn reduce | ||
| "f should be a function of 2 arguments. If val is not supplied, |
robatron
Apr 3, 2017
Author
Apologies for the hard wrap diff gore. I changed the first sentence from:
f should be a function of 2 arguments.
to:
f should be a function of 2 arguments: 1st, the accumulator, and 2nd the current element.
Apologies for the hard wrap diff gore. I changed the first sentence from:
f should be a function of 2 arguments.
to:
f should be a function of 2 arguments: 1st, the accumulator, and 2nd the current element.
|
You'll get the usual "We don't accept pull requests" comment. You need to use JIRA and file Article 239823 and fill in relevant release forms from Paragrah 63a Alpha, subparagraph 12 and ensure you click "accept trans dimensional JIRA brain uplink" when prompted. |
|
To be a little more precise :-) You can find links for "Sign up for a JIRA account" and "Creating Tickets" on this page: http://dev.clojure.org/display/community/Contributing Instructions for signing a Clojure Contributor Agreement are here, only necessary if you wish to contribute code to Clojure: https://clojure.org/community/contributing |
|
@AeroNotix @jafingerhut indeed, hence:
I.e., is the proposed change acceptable? As a complete clojure newb, I just want to make sure I'm not overlooking something obvious before contributing. |
|
^the above is exactly why a complicated contribution process is not helpful to beginners and drive-by pull requests. |
|
@robatron all it means that Clojure does not use GitHub pull requests. You will go through a hand crafted 16th century style software development process before you know if your change is worth accepting. They used to ask for a snail mail sent to North Carolina before you could contribute anything (this is not a joke). |
|
@robatron There is only one person who can give the final answer on whether a contribution is acceptable or not, and that is Rich Hickey. In practice, Alex Miller has a pretty good feel for what is interesting or not, and he reads the Clojure Google group where anyone can publish messages, and he often answers questions like this. Or, create a JIRA ticket (no signing of a Clojure CA required), and he can address that question. |
Hello, I'm a first-time user of clojure, and thought the
reducecore function docs could use clarification regarding its callback function's arguments.I just noticed this project does not accept pull requests via github, but I figured this PR would be a good way to communicate my intended contribution before learning how to contribute a patch via JIRA.