The Wayback Machine - https://web.archive.org/web/20200906014331/https://github.com/web-push-libs/web-push-php/pull/220
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix base64encode issue #220

Merged
merged 4 commits into from Mar 23, 2019
Merged

fix base64encode issue #220

merged 4 commits into from Mar 23, 2019

Conversation

@vockalimo
Copy link
Contributor

vockalimo commented Mar 7, 2019

due to
base64encode could be generate "="
recommend to change base64urlencode to avoid this issue

vocka
Copy link
Member

Minishlink left a comment

Thanks for the contribution, please fix this small error :)

src/VAPID.php Outdated Show resolved Hide resolved
vocka added 2 commits Mar 8, 2019
vocka
vocka
tests/VAPIDTest.php Outdated Show resolved Hide resolved
@vockalimo
Copy link
Contributor Author

vockalimo commented Mar 12, 2019

hmm ...
phpstan check fail , phpstan upgrade new version
array-key-exists check fail , i don't why , maybe phpstan bug

@Minishlink
Copy link
Member

Minishlink commented Mar 15, 2019

Yes it's a phpstan bug that has been fixed, I'll merge your pr this week-end :)

@vockalimo
Copy link
Contributor Author

vockalimo commented Mar 19, 2019

great ~~ thank

@Minishlink Minishlink merged commit b1e09e9 into web-push-libs:master Mar 23, 2019
1 check failed
1 check failed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
marcvdm added a commit to level23/web-push-php that referenced this pull request Jun 14, 2019
*  fix base64encode issue

*  typo ~ fix Base64Url::encode

*  fix phpunit testing

*  fix The condition becomes ">=86" and ">=42"
marcvdm added a commit to level23/web-push-php that referenced this pull request Jun 14, 2019
*  fix base64encode issue

*  typo ~ fix Base64Url::encode

*  fix phpunit testing

*  fix The condition becomes ">=86" and ">=42"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.