The Wayback Machine - https://web.archive.org/web/20200304104556/https://github.com/pandas-dev/pandas/pull/24529
Skip to content
Sign in Sign up

/ pandas

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix db usage in CI #24529

Merged
merged 4 commits into from Jan 1, 2019
Merged

CI: fix db usage in CI #24529

merged 4 commits into from Jan 1, 2019

Conversation

@jreback
Copy link
Contributor

jreback commented Jan 1, 2019 •
edited

closes #24528
reverts behavior in #24485
canonical way to run tests is test_fast.sh (or can also specify -m 'not single' (or --skip-db)
@jreback
CI: fix db usage in CI
Loading status checks…
6293848 
closes #24528
@jreback jreback added the CI label Jan 1, 2019
@jreback jreback added this to the 0.24.0 milestone Jan 1, 2019
@jreback
moar
Loading status checks…
b30cfdb
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Jan 1, 2019

Codecov Report

Merging #24529 into master will increase coverage by 10.93%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24529       +/-   ##
===========================================
+ Coverage   31.88%   42.81%   +10.93%     
===========================================
  Files         166      166               
  Lines       52427    52427               
===========================================
+ Hits        16714    22445     +5731     
+ Misses      35713    29982     -5731
Flag Coverage Δ
#multiple ?
#single 42.81% <ø> (+10.93%) ⬆️
Impacted Files Coverage Δ
pandas/core/indexes/accessors.py 54% <0%> (-10%) ⬇️
pandas/core/internals/concat.py 60.07% <0%> (-7.12%) ⬇️
pandas/core/nanops.py 32.07% <0%> (+0.37%) ⬆️
pandas/core/arrays/period.py 41.54% <0%> (+0.93%) ⬆️
pandas/core/dtypes/missing.py 58.52% <0%> (+1.13%) ⬆️
pandas/core/arrays/base.py 57.05% <0%> (+1.17%) ⬆️
pandas/io/formats/csvs.py 68.63% <0%> (+1.18%) ⬆️
pandas/core/arrays/timedeltas.py 40% <0%> (+1.23%) ⬆️
pandas/tseries/offsets.py 45.63% <0%> (+1.35%) ⬆️
pandas/compat/__init__.py 49.8% <0%> (+1.54%) ⬆️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9284a2...b30cfdb. Read the comment docs.
@codecov

This comment has been minimized.

Sign in to view
Copy link

codecov bot commented Jan 1, 2019 •
edited

Codecov Report

Merging #24529 into master will increase coverage by 60.43%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #24529       +/-   ##
===========================================
+ Coverage   31.88%   92.31%   +60.43%     
===========================================
  Files         166      166               
  Lines       52427    52427               
===========================================
+ Hits        16714    48398    +31684     
+ Misses      35713     4029    -31684
Flag Coverage Δ
#multiple 90.73% <0%> (+60.45%) ⬆️
#single 43.01% <0%> (+11.13%) ⬆️
Impacted Files Coverage Δ
pandas/util/_tester.py 23.8% <0%> (ø) ⬆️
pandas/util/_test_decorators.py 90.54% <0%> (+4.05%) ⬆️
pandas/compat/__init__.py 57.91% <0%> (+9.65%) ⬆️
pandas/core/config_init.py 99.24% <0%> (+9.84%) ⬆️
pandas/core/reshape/util.py 100% <0%> (+11.53%) ⬆️
pandas/core/api.py 100% <0%> (+13.33%) ⬆️
pandas/compat/numpy/__init__.py 92.85% <0%> (+14.28%) ⬆️
pandas/io/formats/console.py 74.24% <0%> (+16.66%) ⬆️
pandas/core/dtypes/inference.py 98.46% <0%> (+18.46%) ⬆️
pandas/plotting/_compat.py 87.5% <0%> (+18.75%) ⬆️
... and 126 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9284a2...24e5d6b. Read the comment docs.
jreback and others added 2 commits Jan 1, 2019
@jreback
revert
Loading status checks…
abbf105
@datapythonista
Fix linting error: unused import
Loading status checks…
24e5d6b
@jreback

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jreback commented Jan 1, 2019

thanks @datapythonista i think this is good now.
@datapythonista
datapythonista reviewed Jan 1, 2019
View changes
Copy link
Member

datapythonista left a comment •
edited

Sorry for the trouble.

I pushed a linting fix. I think just adding the brackets after the single/not single filter in run_tests.sh, and changing the and by the or is possibly enough.

But the filter to skip db tests by default is probably too complex for being untested, it's probably a good idea to remove it if the --skip-db is enough.
.travis.yml

- dist: trusty
env:
- JOB="2.7" ENV_FILE="ci/deps/travis-27.yaml" PATTERN="not slow and db"
- JOB="2.7" ENV_FILE="ci/deps/travis-27.yaml" PATTERN="(not slow or (single and db))"

This comment has been minimized.

Sign in to view
Copy link
@datapythonista

datapythonista Jan 1, 2019

Member

Just realized about my mistake now. not slow and db just runs db tests. I think not slow or db should be enough, I guess I'm missing something, but I don't see why the single is needed here.

I think it's probably better to add the brackets in run_tests.sh.

This comment has been minimized.

Sign in to view
Copy link
@jreback

jreback Jan 1, 2019

Author Contributor

no, the single that is added makes this a bit odd, eg. we are adding the single and pattern, and we only want to run the db tests when its single
@jreback

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

jreback commented Jan 1, 2019

@datapythonista so welcome to simplify this, but in a followup.
@jreback jreback merged commit c5af282 into pandas-dev:master Jan 1, 2019
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
pandas-dev.pandas Build #20190101.34 succeeded
Details
thoo added a commit to thoo/pandas that referenced this pull request Jan 1, 2019
@thoo
Merge remote-tracking branch 'upstream/master' into isort-io
Loading status checks…
6928413 
* upstream/master:
  Make DTI[tz]._values and Series[tz]._values return DTA (pandas-dev#24534)
  CLN: Refactor some sorting code in Index set operations (pandas-dev#24533)
  Run isort (pandas-dev#24530)
  CI: fix db usage in CI (pandas-dev#24529)
Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jreback @Pingviinituutti
CI: fix db usage in CI (pandas-dev#24529)
6996b57
Pingviinituutti added a commit to Pingviinituutti/pandas that referenced this pull request Feb 28, 2019
@jreback @Pingviinituutti
CI: fix db usage in CI (pandas-dev#24529)
c562daf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datapythonista datapythonista

Assignees
No one assigned
Labels
CI
Projects
None yet
Milestone
  0.24.0
Linked issues

Successfully merging this pull request may close these issues.

CI: db option is skipping lots of tests
2 participants
@jreback @datapythonista
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.