Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign updomProps set to null or undefined are set to '' on update. #9650
Comments
This comment has been minimized.
This comment has been minimized.
|
This is expected because a dom prop is casted by the browser into a string |
posva
closed this
Mar 7, 2019
This comment has been minimized.
This comment has been minimized.
|
@posva What browser casts dom props into strings? They're not attributes and not expressed as such, and I've been using |
Justineo
reopened this
Mar 8, 2019
This comment has been minimized.
This comment has been minimized.
|
It seems that now when |
This comment has been minimized.
This comment has been minimized.
|
Oh yeah, my bad was thinking about attributes
On Fri 8 Mar 2019 at 05:08, GU Yiling ***@***.***> wrote:
It seems that now when domProps are updated, undefined and null will be
converted to '' (empty string).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#9650 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAoicbZ9UM5-BAkCGv2pEOy7wFR4ijx9ks5vUeJagaJpZM4bkMxV>
.
--
Eduardo San Martin Morote
|
This comment has been minimized.
This comment has been minimized.
pistis
commented
Mar 19, 2019
•
|
@posva When the x value of domProps is set to undefined
Test Scenario 2
Also, if x value of domProps is set to null, the same result as above is displayed. I estimate the following.
|


MayaWolf commentedMar 7, 2019
•
edited
Version
2.6.8
Reproduction link
https://jsfiddle.net/bqzu8crg/
Steps to reproduce
Since this change, whenever an element updates which has one of its domProps set to
undefinedornull, that prop is instead set to''.All you need to do to reproduce it is render an element with properties in
domPropsset to null or undefined, and then update the component.What is expected?
The domProps values retain their correct types.
What is actually happening?
The domProps become strings, instead.