The Wayback Machine - https://web.archive.org/web/20190322173411/https://github.com/vuejs/vue/issues/9727
Skip to content
Sign in Sign up

/vue

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type of VNodeData style property should accept string values #9727

Closed
VitorLuizC opened this Issue Mar 17, 2019 · 5 comments
Closed

Type of VNodeData style property should accept string values #9727

VitorLuizC opened this Issue Mar 17, 2019 · 5 comments

Comments

Assignees
No one assigned
Labels
has PR typescript
Projects
None yet
Milestone
No milestone
2 participants
@VitorLuizC @posva
@VitorLuizC
Copy link
Contributor

VitorLuizC commented Mar 17, 2019

Version

2.6.9

Reproduction link

https://codesandbox.io/s/pkpkn7ljym

Steps to reproduce

Just try to use a string value for VNodeData's style property.

What is expected?

Vue handle string values for style, so types should allow the same.

What is actually happening?

Type of VNodeData's style don't accept string values.

@flow type declarations has same issue.

@VitorLuizC VitorLuizC referenced this issue Mar 17, 2019

Merged

fix #9727 #9728

5 of 13 tasks complete

@posva posva added the typescript label Mar 17, 2019

@posva

This comment has been minimized.

Sign in to view
Copy link
Member

posva commented Mar 17, 2019

when do you have a string property in style? Are you creating or modifying existing vnodes (they are read-only)

@posva posva added the has PR label Mar 17, 2019

@VitorLuizC

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

VitorLuizC commented Mar 17, 2019

When I'm creating them. The problems happens exactly when I'm creating components with createElement and VNodeData's style can't be string, even Vue supporting it.
@posva

This comment has been minimized.

Sign in to view
Copy link
Member

posva commented Mar 17, 2019

Ok, I was confused because you directly used the type on a variable instead of passing the object with not type to h
@VitorLuizC

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

VitorLuizC commented Mar 17, 2019

Sorry, my example may be bad.

I also found on sources the function where Vue handle string values for style bindings (if it help).

vue/src/platforms/web/util/style.js

Lines 29 to 34 in 653c74e

export function normalizeStyleBinding (bindingStyle: any): ?Object {
if (Array.isArray(bindingStyle)) {
return toObject(bindingStyle)
}
if (typeof bindingStyle === 'string') {
return parseStyleText(bindingStyle)

@posva

This comment has been minimized.

Sign in to view
Copy link
Member

posva commented Mar 17, 2019

It was good already, but thanks for sharing :)

@yyx990803 yyx990803 closed this in #9728 Mar 18, 2019

yyx990803 added a commit that referenced this issue Mar 18, 2019

@VitorLuizC @yyx990803
fix(types): support string type for style in VNode data (#9728) 
fix #9727
Loading status checks…
982d5a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
Morty Proxy This is a proxified and sanitized view of the page, visit original site.